[SPARK-10584][DOC][SQL] Documentation about spark.sql.hive.metastore.version is wrong.#8739
Closed
sarutak wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-10584][DOC][SQL] Documentation about spark.sql.hive.metastore.version is wrong.#8739sarutak wants to merge 3 commits intoapache:masterfrom
sarutak wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
That looks right just reading the code but I'm not an expert. |
|
Test build #42406 has finished for PR 8739 at commit
|
Contributor
|
LGTM. Merging to master and branch 1.5. |
asfgit
pushed a commit
that referenced
this pull request
Sep 14, 2015
…e.version is wrong.
The default value of hive metastore version is 1.2.1 but the documentation says the value of `spark.sql.hive.metastore.version` is 0.13.1.
Also, we cannot get the default value by `sqlContext.getConf("spark.sql.hive.metastore.version")`.
Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Closes #8739 from sarutak/SPARK-10584.
(cherry picked from commit cf2821e)
Signed-off-by: Yin Huai <yhuai@databricks.com>
Member
Author
|
@yhuai I found some more Are these collect? |
Contributor
|
@sarutak Looks like they need to be updated. Can you send another PR? Thanks! |
Member
Author
|
O.K. I'll do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value of hive metastore version is 1.2.1 but the documentation says the value of
spark.sql.hive.metastore.versionis 0.13.1.Also, we cannot get the default value by
sqlContext.getConf("spark.sql.hive.metastore.version").